Fixing attachment_fu on Windows
Like many others, I've encountered issue when developing Rails applications using attachment_fu on Windows. After doing some research, I've come up with the following solution to the problem.The problem has two parts :
- Size is not included in the list error message,
- Timeout error when uploading to S3.
Fixing "Size is not included in the list" error message
Some people have reported that there is a timing issue, when trying to get the file size, with Tempfile on Windows. It seems that the size of the file is not properly reported by Windows after writing data to it. Proposed solutions for this problem include :- Sleeping in a loop as long as the file size is 0,
- Reading back the entire file in memory.
I think I found a better and less patchy solution for this issue: forcing the OS to flush the file to disk before reading it's size.
Here is the code to do it :
require 'tempfile'
class Tempfile
def size
if @tmpfile
@tmpfile.fsync # added this line
@tmpfile.flush
@tmpfile.stat.size
else@tmpfile.flush
@tmpfile.stat.size
0
endend
end
Doing a flush is not enough... flush will flush the Ruby buffer but the file may not be immediately written to the disk by the OS. Doing the fsync ensure that the file is written to disk by the OS before continuing. After that, Windows will properly report the actual file size.Fixing the Timeout error when uploading to S3
This issue is related to opening files for reading on Windows. On Windows, you have to open the file in binary mode. So patching attachment_fu is simple :require 'technoweenie/attachment_fu/backends/s3_backend'
module Technoweenie
module Technoweenie
module AttachmentFu
endmodule Backends
endmodule S3Backend
endprotected
def save_to_storage
enddef save_to_storage
if save_attachment?
@old_filename = nil
true
endS3Object.store(
endfull_filename,
(temp_path ? File.open(temp_path, "rb") : temp_data), # added , "rb"
bucket_name,
:content_type => content_type,
:access => attachment_options[:s3_access]
)(temp_path ? File.open(temp_path, "rb") : temp_data), # added , "rb"
bucket_name,
:content_type => content_type,
:access => attachment_options[:s3_access]
@old_filename = nil
true
I've also included a fix from someone else (which was not enough in itself to solve my S3 upload problem):
module Technoweenie
module AttachmentFu
end# Gets the data from the latest temp file. This will read the file into memory.
def temp_data
enddef temp_data
if save_attachment?
endf = File.new( temp_path )
f.binmode
return f.read
elsef.binmode
return f.read
return nil
endWrapping it up
So I put all this code in lib/attachment_fu_patch.rb and required it in environment.rb.Problem fixed!
Note, I did not test it on other OSes, but these fixes should not have any adverse effects.